Skip to content

Add annotation_selects tag class #3541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add annotation_selects tag class #3541

wants to merge 1 commit into from
+164 −15

Conversation

finn-ball
Copy link
Contributor

@finn-ball finn-ball commented Aug 4, 2025 •
edited
Loading

Adds an annotation_select tag class.

This annotation will add common environment variables:

crate.annotation(
    crate = "foo",
    build_scipt_data = [
        "@bar",
    ],
    build_script_env = {
        "BAR": "bar",
    },
)

This annotation will append a platform dependent select statement to the above variables:

crate.annotation_select(
    crate = "foo",
    triples = ["x86_64-unknown-linux-gnu"],
    build_script_data = [
        "@baz",
    ],
    build_script_env = {
        "BAZ": "baz",
    },
)

Attempts to improve #3511

illicitonion
illicitonion reviewed Aug 30, 2025
View reviewed changes
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay here!

LGTM - can you patch in (or otherwise achieve) illicitonion@1e5a5ac to error rather than override on duplicate triple setting?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion illicitonion left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@finn-ball @illicitonion